refactor(grpc/client): simplify processEventStream with per-event handlers

- Extract eventHandlers dispatch table - Add per-event handlers: handleSlugChange, handleGetSessions, handleTerminateSession - Introduce sendNode helper to centralize send/error handling and preserve connection-error propagation - Add protoToTunnelType for tunnel-type validation - Map unknown proto.TunnelType to types.UNKNOWN in protoToTunnelType and return a descriptive error - Reduce boilerplate and improve readability of processEventStream
2026-01-06 20:14:56 +07:00
parent 6213ff8a30
commit 16d48ff906
2 changed files with 141 additions and 193 deletions
--- a/internal/grpc/client/client.go
+++ b/internal/grpc/client/client.go
@@ -210,84 +210,71 @@ func (c *Client) SubscribeEvents(ctx context.Context, identity, authToken string
 }

 func (c *Client) processEventStream(subscribe grpc.BidiStreamingClient[proto.Node, proto.Events]) error {
+	handlers := c.eventHandlers(subscribe)
+
 	for {
 		recv, err := subscribe.Recv()
 		if err != nil {
 			return err
 		}
-		switch recv.GetType() {
-		case proto.EventType_SLUG_CHANGE:
-			user := recv.GetSlugEvent().GetUser()
-			oldSlug := recv.GetSlugEvent().GetOld()
-			newSlug := recv.GetSlugEvent().GetNew()
-			var userSession *session.SSHSession
-			userSession, err = c.sessionRegistry.Get(types.SessionKey{
-				Id:   oldSlug,
-				Type: types.HTTP,
-			})
-			if err != nil {
-				errSend := subscribe.Send(&proto.Node{
-					Type: proto.EventType_SLUG_CHANGE_RESPONSE,
-					Payload: &proto.Node_SlugEventResponse{
-						SlugEventResponse: &proto.SlugChangeEventResponse{
-							Success: false,
-							Message: err.Error(),
-						},
-					},
-				})
-				if errSend != nil {
-					if c.isConnectionError(errSend) {
-						return errSend
-					}
-					log.Printf("non-connection send error for slug change failure: %v", errSend)
-				}
+
+		handler, ok := handlers[recv.GetType()]
+		if !ok {
+			log.Printf("Unknown event type received: %v", recv.GetType())
 			continue
 		}
-			err = c.sessionRegistry.Update(user, types.SessionKey{
-				Id:   oldSlug,
-				Type: types.HTTP,
-			}, types.SessionKey{
-				Id:   newSlug,
-				Type: types.HTTP,
-			})
-			if err != nil {
-				errSend := subscribe.Send(&proto.Node{
-					Type: proto.EventType_SLUG_CHANGE_RESPONSE,
-					Payload: &proto.Node_SlugEventResponse{
-						SlugEventResponse: &proto.SlugChangeEventResponse{
-							Success: false,
-							Message: err.Error(),
-						},
-					},
-				})
-				if errSend != nil {
-					if c.isConnectionError(errSend) {
-						return errSend
-					}
-					log.Printf("non-connection send error for slug change failure: %v", errSend)
-				}
-				continue
-			}
-			userSession.GetInteraction().Redraw()
-			err = subscribe.Send(&proto.Node{
-				Type: proto.EventType_SLUG_CHANGE_RESPONSE,
-				Payload: &proto.Node_SlugEventResponse{
-					SlugEventResponse: &proto.SlugChangeEventResponse{
-						Success: true,
-						Message: "",
-					},
-				},
-			})
-			if err != nil {
-				if c.isConnectionError(err) {
-					log.Printf("connection error sending slug change success: %v", err)
+
+		if err = handler(recv); err != nil {
 			return err
 		}
-				log.Printf("non-connection send error for slug change success: %v", err)
-				continue
 	}
-		case proto.EventType_GET_SESSIONS:
-			sessions := c.sessionRegistry.GetAllSessionFromUser(recv.GetGetSessionsEvent().GetIdentity())
+}
+
+func (c *Client) eventHandlers(subscribe grpc.BidiStreamingClient[proto.Node, proto.Events]) map[proto.EventType]func(*proto.Events) error {
+	return map[proto.EventType]func(*proto.Events) error{
+		proto.EventType_SLUG_CHANGE:       func(evt *proto.Events) error { return c.handleSlugChange(subscribe, evt) },
+		proto.EventType_GET_SESSIONS:      func(evt *proto.Events) error { return c.handleGetSessions(subscribe, evt) },
+		proto.EventType_TERMINATE_SESSION: func(evt *proto.Events) error { return c.handleTerminateSession(subscribe, evt) },
+	}
+}
+
+func (c *Client) handleSlugChange(subscribe grpc.BidiStreamingClient[proto.Node, proto.Events], evt *proto.Events) error {
+	slugEvent := evt.GetSlugEvent()
+	user := slugEvent.GetUser()
+	oldSlug := slugEvent.GetOld()
+	newSlug := slugEvent.GetNew()
+
+	userSession, err := c.sessionRegistry.Get(types.SessionKey{Id: oldSlug, Type: types.HTTP})
+	if err != nil {
+		return c.sendNode(subscribe, &proto.Node{
+			Type: proto.EventType_SLUG_CHANGE_RESPONSE,
+			Payload: &proto.Node_SlugEventResponse{
+				SlugEventResponse: &proto.SlugChangeEventResponse{Success: false, Message: err.Error()},
+			},
+		}, "slug change failure response")
+	}
+
+	if err = c.sessionRegistry.Update(user, types.SessionKey{Id: oldSlug, Type: types.HTTP}, types.SessionKey{Id: newSlug, Type: types.HTTP}); err != nil {
+		return c.sendNode(subscribe, &proto.Node{
+			Type: proto.EventType_SLUG_CHANGE_RESPONSE,
+			Payload: &proto.Node_SlugEventResponse{
+				SlugEventResponse: &proto.SlugChangeEventResponse{Success: false, Message: err.Error()},
+			},
+		}, "slug change failure response")
+	}
+
+	userSession.GetInteraction().Redraw()
+	return c.sendNode(subscribe, &proto.Node{
+		Type: proto.EventType_SLUG_CHANGE_RESPONSE,
+		Payload: &proto.Node_SlugEventResponse{
+			SlugEventResponse: &proto.SlugChangeEventResponse{Success: true, Message: ""},
+		},
+	}, "slug change success response")
+}
+
+func (c *Client) handleGetSessions(subscribe grpc.BidiStreamingClient[proto.Node, proto.Events], evt *proto.Events) error {
+	sessions := c.sessionRegistry.GetAllSessionFromUser(evt.GetGetSessionsEvent().GetIdentity())
+
 	var details []*proto.Detail
 	for _, ses := range sessions {
 		detail := ses.Detail()
@@ -300,115 +287,75 @@ func (c *Client) processEventStream(subscribe grpc.BidiStreamingClient[proto.Nod
 			StartedAt:      timestamppb.New(detail.StartedAt),
 		})
 	}
-			err = subscribe.Send(&proto.Node{
+
+	return c.sendNode(subscribe, &proto.Node{
 		Type: proto.EventType_GET_SESSIONS,
 		Payload: &proto.Node_GetSessionsEvent{
-					GetSessionsEvent: &proto.GetSessionsResponse{
-						Details: details,
+			GetSessionsEvent: &proto.GetSessionsResponse{Details: details},
 		},
-				},
-			})
-			if err != nil {
-				if c.isConnectionError(err) {
-					log.Printf("connection error sending sessions success: %v", err)
-					return err
-				}
-				log.Printf("non-connection send error for sessions success: %v", err)
-				continue
-			}
-		case proto.EventType_TERMINATE_SESSION:
-			user := recv.GetTerminateSessionEvent().GetUser()
-			tunnelTypeRaw := recv.GetTerminateSessionEvent().GetTunnelType()
-			slug := recv.GetTerminateSessionEvent().GetSlug()
+	}, "send get sessions response")
+}

-			var userSession *session.SSHSession
-			var tunnelType types.TunnelType
-			if tunnelTypeRaw == proto.TunnelType_HTTP {
-				tunnelType = types.HTTP
-			} else if tunnelTypeRaw == proto.TunnelType_TCP {
-				tunnelType = types.TCP
-			} else {
-				err = subscribe.Send(&proto.Node{
+func (c *Client) handleTerminateSession(subscribe grpc.BidiStreamingClient[proto.Node, proto.Events], evt *proto.Events) error {
+	terminate := evt.GetTerminateSessionEvent()
+	user := terminate.GetUser()
+	slug := terminate.GetSlug()
+
+	tunnelType, err := c.protoToTunnelType(terminate.GetTunnelType())
+	if err != nil {
+		return c.sendNode(subscribe, &proto.Node{
 			Type: proto.EventType_TERMINATE_SESSION,
 			Payload: &proto.Node_TerminateSessionEventResponse{
-						TerminateSessionEventResponse: &proto.TerminateSessionEventResponse{
-							Success: false,
-							Message: "unknown tunnel type recived",
+				TerminateSessionEventResponse: &proto.TerminateSessionEventResponse{Success: false, Message: err.Error()},
 			},
-					},
-				})
+		}, "terminate session invalid tunnel type")
+	}
+
+	userSession, err := c.sessionRegistry.GetWithUser(user, types.SessionKey{Id: slug, Type: tunnelType})
 	if err != nil {
-					if c.isConnectionError(err) {
-						log.Printf("connection error sending sessions success: %v", err)
-						return err
-					}
-					log.Printf("non-connection send error for sessions success: %v", err)
-				}
-				continue
-			}
-			userSession, err = c.sessionRegistry.GetWithUser(user, types.SessionKey{
-				Id:   slug,
-				Type: tunnelType,
-			})
-			if err != nil {
-				err = subscribe.Send(&proto.Node{
+		return c.sendNode(subscribe, &proto.Node{
 			Type: proto.EventType_TERMINATE_SESSION,
 			Payload: &proto.Node_TerminateSessionEventResponse{
-						TerminateSessionEventResponse: &proto.TerminateSessionEventResponse{
-							Success: false,
-							Message: err.Error(),
+				TerminateSessionEventResponse: &proto.TerminateSessionEventResponse{Success: false, Message: err.Error()},
 			},
-					},
-				})
-				if err != nil {
-					if c.isConnectionError(err) {
-						log.Printf("connection error sending sessions success: %v", err)
-						return err
+		}, "terminate session fetch failed")
 	}
-					log.Printf("non-connection send error for sessions success: %v", err)
-				}
-				continue
-			}
-			err = userSession.GetLifecycle().Close()
-			if err != nil {
-				err = subscribe.Send(&proto.Node{
+
+	if err = userSession.GetLifecycle().Close(); err != nil {
+		return c.sendNode(subscribe, &proto.Node{
 			Type: proto.EventType_TERMINATE_SESSION,
 			Payload: &proto.Node_TerminateSessionEventResponse{
-						TerminateSessionEventResponse: &proto.TerminateSessionEventResponse{
-							Success: false,
-							Message: err.Error(),
+				TerminateSessionEventResponse: &proto.TerminateSessionEventResponse{Success: false, Message: err.Error()},
 			},
-					},
-				})
-				if err != nil {
-					if c.isConnectionError(err) {
-						log.Printf("connection error sending sessions success: %v", err)
-						return err
+		}, "terminate session close failed")
 	}
-					log.Printf("non-connection send error for sessions success: %v", err)
-				}
-				continue
-			}
-			err = subscribe.Send(&proto.Node{
+
+	return c.sendNode(subscribe, &proto.Node{
 		Type: proto.EventType_TERMINATE_SESSION,
 		Payload: &proto.Node_TerminateSessionEventResponse{
-					TerminateSessionEventResponse: &proto.TerminateSessionEventResponse{
-						Success: true,
-						Message: "",
+			TerminateSessionEventResponse: &proto.TerminateSessionEventResponse{Success: true, Message: ""},
 		},
-				},
-			})
-			if err != nil {
+	}, "terminate session success response")
+}
+
+func (c *Client) sendNode(subscribe grpc.BidiStreamingClient[proto.Node, proto.Events], node *proto.Node, context string) error {
+	if err := subscribe.Send(node); err != nil {
 		if c.isConnectionError(err) {
-					log.Printf("connection error sending sessions success: %v", err)
 			return err
 		}
-				log.Printf("non-connection send error for sessions success: %v", err)
-				continue
+		log.Printf("%s: %v", context, err)
 	}
+	return nil
+}
+
+func (c *Client) protoToTunnelType(t proto.TunnelType) (types.TunnelType, error) {
+	switch t {
+	case proto.TunnelType_HTTP:
+		return types.HTTP, nil
+	case proto.TunnelType_TCP:
+		return types.TCP, nil
 	default:
-			log.Printf("Unknown event type received: %v", recv.GetType())
-		}
+		return types.UNKNOWN, fmt.Errorf("unknown tunnel type received")
 	}
 }

--- a/types/types.go
+++ b/types/types.go
@@ -11,6 +11,7 @@ const (
 type TunnelType string

 const (
+	UNKNOWN TunnelType = "UNKNOWN"
 	HTTP    TunnelType = "HTTP"
 	TCP     TunnelType = "TCP"
 )