bagas/tunnel-please
Public Access
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: prevent race condition when channel is used before being set
All checks were successful
Docker Build and Push / build-and-push (push) Successful in 6m24s
Details

Browse Source
This commit is contained in:
bagas
2025-12-08 22:46:10 +07:00
parent cb08bb7673
commit c951c41a9b
1 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
session/session.go
View File

@ -71,9 +71,6 @@ func New(conn *ssh.ServerConn, forwardingReq <-chan *ssh.Request, sshChan <-chan
SlugManager: slugManager, SlugManager: slugManager,
} }
go func() {
go session.Lifecycle.WaitForRunningStatus()
for channel := range sshChan { for channel := range sshChan {
ch, reqs, err := channel.Accept() ch, reqs, err := channel.Accept()
if err != nil { if err != nil {
@ -85,6 +82,7 @@ func New(conn *ssh.ServerConn, forwardingReq <-chan *ssh.Request, sshChan <-chan
session.Interaction.SetChannel(ch) session.Interaction.SetChannel(ch)
session.Lifecycle.SetStatus(types.SETUP) session.Lifecycle.SetStatus(types.SETUP)
go session.HandleGlobalRequest(forwardingReq) go session.HandleGlobalRequest(forwardingReq)
session.Lifecycle.WaitForRunningStatus()
}) })
go session.HandleGlobalRequest(reqs) go session.HandleGlobalRequest(reqs)
@ -92,7 +90,6 @@ func New(conn *ssh.ServerConn, forwardingReq <-chan *ssh.Request, sshChan <-chan
if err := session.Lifecycle.Close(); err != nil { if err := session.Lifecycle.Close(); err != nil {
log.Printf("failed to close session: %v", err) log.Printf("failed to close session: %v", err)
} }
}()
} }
func updateClientSlug(oldSlug, newSlug string) bool { func updateClientSlug(oldSlug, newSlug string) bool {