Merge pull request 'staging' (#35) from staging into main

Reviewed-on: #35

.gitea/workflows/build.yml

@@ -30,7 +30,7 @@ jobs:
           context: .
           push: true
           tags: |
-            git.fossy.my.id/${{ secrets.DOCKER_USERNAME }}/tunnl_please:latest
+            git.fossy.my.id/${{ secrets.DOCKER_USERNAME }}/tunnel-please:latest
           platforms: linux/amd64,linux/arm64
         if: github.ref == 'refs/heads/main'
 
@@ -40,6 +40,6 @@ jobs:
           context: .
           push: true
           tags: |
-            git.fossy.my.id/${{ secrets.DOCKER_USERNAME }}/tunnl_please:staging
+            git.fossy.my.id/${{ secrets.DOCKER_USERNAME }}/tunnel-please:staging
           platforms: linux/amd64,linux/arm64
         if: github.ref == 'refs/heads/staging'

README.md

@@ -1,93 +1,35 @@
-# tunnel_pls
+# Tunnel Please
 
+A lightweight SSH-based tunnel server written in Go that enables secure TCP and HTTP forwarding with an interactive terminal interface for managing connections and custom subdomains.
 
+## Features
 
-## Getting started
+- SSH interactive session with real-time command handling
+- Custom subdomain management for HTTP tunnels
+- Active connection control with drop functionality
+- Dual protocol support: HTTP and TCP tunnels
+- Real-time connection monitoring
+## Requirements
 
-To make it easy for you to get started with GitLab, here's a list of recommended next steps.
-
-Already a pro? Just edit this README.md and make it your own. Want to make it easy? [Use the template at the bottom](#editing-this-readme)!
-
-## Add your files
-
-- [ ] [Create](https://docs.gitlab.com/ee/user/project/repository/web_editor.html#create-a-file) or [upload](https://docs.gitlab.com/ee/user/project/repository/web_editor.html#upload-a-file) files
-- [ ] [Add files using the command line](https://docs.gitlab.com/ee/gitlab-basics/add-file.html#add-a-file-using-the-command-line) or push an existing Git repository with the following command:
-
-```
-cd existing_repo
-git remote add origin http://git.fossy.my.id/bagas/tunnel_pls.git
-git branch -M main
-git push -uf origin main
-```
-
-## Integrate with your tools
-
-- [ ] [Set up project integrations](http://git.fossy.my.id/bagas/tunnel_pls/-/settings/integrations)
-
-## Collaborate with your team
-
-- [ ] [Invite team members and collaborators](https://docs.gitlab.com/ee/user/project/members/)
-- [ ] [Create a new merge request](https://docs.gitlab.com/ee/user/project/merge_requests/creating_merge_requests.html)
-- [ ] [Automatically close issues from merge requests](https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#closing-issues-automatically)
-- [ ] [Enable merge request approvals](https://docs.gitlab.com/ee/user/project/merge_requests/approvals/)
-- [ ] [Set auto-merge](https://docs.gitlab.com/ee/user/project/merge_requests/merge_when_pipeline_succeeds.html)
-
-## Test and Deploy
-
-Use the built-in continuous integration in GitLab.
-
-- [ ] [Get started with GitLab CI/CD](https://docs.gitlab.com/ee/ci/quick_start/index.html)
-- [ ] [Analyze your code for known vulnerabilities with Static Application Security Testing (SAST)](https://docs.gitlab.com/ee/user/application_security/sast/)
-- [ ] [Deploy to Kubernetes, Amazon EC2, or Amazon ECS using Auto Deploy](https://docs.gitlab.com/ee/topics/autodevops/requirements.html)
-- [ ] [Use pull-based deployments for improved Kubernetes management](https://docs.gitlab.com/ee/user/clusters/agent/)
-- [ ] [Set up protected environments](https://docs.gitlab.com/ee/ci/environments/protected_environments.html)
-
-***
-
-# Editing this README
-
-When you're ready to make this README your own, just edit this file and use the handy template below (or feel free to structure it however you want - this is just a starting point!). Thanks to [makeareadme.com](https://www.makeareadme.com/) for this template.
-
-## Suggestions for a good README
-
-Every project is different, so consider which of these sections apply to yours. The sections used in the template are suggestions for most open source projects. Also keep in mind that while a README can be too long and detailed, too long is better than too short. If you think your README is too long, consider utilizing another form of documentation rather than cutting out information.
-
-## Name
-Choose a self-explaining name for your project.
-
-## Description
-Let people know what your project can do specifically. Provide context and add a link to any reference visitors might be unfamiliar with. A list of Features or a Background subsection can also be added here. If there are alternatives to your project, this is a good place to list differentiating factors.
-
-## Badges
-On some READMEs, you may see small images that convey metadata, such as whether or not all the tests are passing for the project. You can use Shields to add some to your README. Many services also have instructions for adding a badge.
-
-## Visuals
-Depending on what you are making, it can be a good idea to include screenshots or even a video (you'll frequently see GIFs rather than actual videos). Tools like ttygif can help, but check out Asciinema for a more sophisticated method.
-
-## Installation
-Within a particular ecosystem, there may be a common way of installing things, such as using Yarn, NuGet, or Homebrew. However, consider the possibility that whoever is reading your README is a novice and would like more guidance. Listing specific steps helps remove ambiguity and gets people to using your project as quickly as possible. If it only runs in a specific context like a particular programming language version or operating system or has dependencies that have to be installed manually, also add a Requirements subsection.
-
-## Usage
-Use examples liberally, and show the expected output if you can. It's helpful to have inline the smallest example of usage that you can demonstrate, while providing links to more sophisticated examples if they are too long to reasonably include in the README.
-
-## Support
-Tell people where they can go to for help. It can be any combination of an issue tracker, a chat room, an email address, etc.
-
-## Roadmap
-If you have ideas for releases in the future, it is a good idea to list them in the README.
+- Go 1.18 or higher
+- Valid domain name for subdomain routing
 
 ## Contributing
-State if you are open to contributions and what your requirements are for accepting them.
+Contributions are welcome!
 
-For people who want to make changes to your project, it's helpful to have some documentation on how to get started. Perhaps there is a script that they should run or some environment variables that they need to set. Make these steps explicit. These instructions could also be useful to your future self.
+If you'd like to contribute to this project, please follow the workflow below:
 
-You can also document commands to lint the code or run tests. These steps help to ensure high code quality and reduce the likelihood that the changes inadvertently break something. Having instructions for running tests is especially helpful if it requires external setup, such as starting a Selenium server for testing in a browser.
-
-## Authors and acknowledgment
-Show your appreciation to those who have contributed to the project.
+1. **Fork** the repository
+2. Create a new branch for your changes
+3. Commit and push your updates
+4. Open a **Pull Request** targeting the **`staging`** branch
+5. Clearly describe your changes and the reasoning behind them
 
 ## License
-For open source projects, say how it is licensed.
+This project is licensed under the [Attribution-NonCommercial-NoDerivatives 4.0 International (CC BY-NC-ND 4.0)](https://creativecommons.org/licenses/by-nc-nd/4.0/) license.
+## Author
+**Bagas (fossyy)**
+
+- Website: [fossy.my.id](https://fossy.my.id)
+- GitHub: [@fossyy](https://github.com/fossyy)
 
-## Project status
-If you have run out of energy or time for your project, put a note at the top of the README saying that development has slowed down or stopped completely. Someone may choose to fork your project or volunteer to step in as a maintainer or owner, allowing your project to keep going. You can also make an explicit request for maintainers.

server/http.go

@@ -11,7 +11,6 @@ import (
 	"regexp"
 	"strings"
 	"tunnel_pls/session"
-	"tunnel_pls/types"
 	"tunnel_pls/utils"
 )
 
@@ -30,7 +29,6 @@ type CustomWriter struct {
 	respMW      []ResponseMiddleware
 	reqStartMW  []RequestMiddleware
 	reqEndMW    []RequestMiddleware
-	overflow    []byte
 }
 
 func (cw *CustomWriter) SetInteraction(interaction Interaction) {
@@ -38,14 +36,6 @@ func (cw *CustomWriter) SetInteraction(interaction Interaction) {
 }
 
 func (cw *CustomWriter) Read(p []byte) (int, error) {
-	if len(cw.overflow) > 0 {
-		n := copy(p, cw.overflow)
-		cw.overflow = cw.overflow[n:]
-		if len(cw.overflow) == 0 {
-			cw.overflow = nil
-		}
-		return n, nil
-	}
 	tmp := make([]byte, len(p))
 	read, err := cw.reader.Read(tmp)
 	if read == 0 && err != nil {
@@ -99,12 +89,6 @@ func (cw *CustomWriter) Read(p []byte) (int, error) {
 
 	n := copy(p, combined)
 
-	if n > len(p) {
-		cw.overflow = make([]byte, len(combined)-n)
-		copy(cw.overflow, combined[n:])
-		log.Printf("output buffer too small (%d vs %d)", len(p), n)
-	}
-
 	return n, nil
 }
 
@@ -118,7 +102,7 @@ func NewCustomWriter(writer io.Writer, reader io.Reader, remoteAddr net.Addr) *C
 	}
 }
 
-var DELIMITER = []byte{0x0D, 0x0A, 0x0D, 0x0A} // HTTP HEADER DELIMITER `\r\n\r\n`
+var DELIMITER = []byte{0x0D, 0x0A, 0x0D, 0x0A}
 var requestLine = regexp.MustCompile(`^(GET|POST|PUT|DELETE|HEAD|OPTIONS|PATCH|TRACE|CONNECT) \S+ HTTP/\d\.\d$`)
 var responseLine = regexp.MustCompile(`^HTTP/\d\.\d \d{3} .+`)
 
@@ -143,8 +127,8 @@ func isHTTPHeader(buf []byte) bool {
 }
 
 func (cw *CustomWriter) Write(p []byte) (int, error) {
-	if len(p) == len(types.BadGatewayResponse) && bytes.Equal(p, types.BadGatewayResponse) {
-		return cw.writer.Write(p)
+	if cw.respHeader != nil && len(cw.buf) == 0 && len(p) >= 5 && string(p[0:5]) == "HTTP/" {
+		cw.respHeader = nil
 	}
 
 	if cw.respHeader != nil {
@@ -166,9 +150,12 @@ func (cw *CustomWriter) Write(p []byte) (int, error) {
 	body := cw.buf[idx+len(DELIMITER):]
 
 	if !isHTTPHeader(header) {
-		n, err := cw.writer.Write(cw.buf)
+		_, err := cw.writer.Write(cw.buf)
 		cw.buf = nil
-		return n, err
+		if err != nil {
+			return 0, err
+		}
+		return len(p), nil
 	}
 
 	resphf := NewResponseHeaderFactory(header)
@@ -323,20 +310,12 @@ func forwardRequest(cw *CustomWriter, initialRequest *RequestHeaderFactory, sshS
 			}
 		}
 	}()
-	_, err = channel.Write(initialRequest.Finalize())
-	if err != nil {
-		log.Printf("Failed to forward request: %v", err)
-		return
-	}
-	//TODO: Implement wrapper func buat add/remove middleware
+
 	fingerprintMiddleware := NewTunnelFingerprint()
-	loggerMiddleware := NewRequestLogger(cw.interaction, cw.RemoteAddr)
 	forwardedForMiddleware := NewForwardedFor(cw.RemoteAddr)
 
 	cw.respMW = append(cw.respMW, fingerprintMiddleware)
-	cw.reqStartMW = append(cw.reqStartMW, loggerMiddleware)
 	cw.reqStartMW = append(cw.reqStartMW, forwardedForMiddleware)
-	//TODO: Tambah req Middleware
 	cw.reqEndMW = nil
 	cw.reqHeader = initialRequest
 
@@ -348,6 +327,12 @@ func forwardRequest(cw *CustomWriter, initialRequest *RequestHeaderFactory, sshS
 		}
 	}
 
+	_, err = channel.Write(initialRequest.Finalize())
+	if err != nil {
+		log.Printf("Failed to forward request: %v", err)
+		return
+	}
+
 	sshSession.Forwarder.HandleConnection(cw, channel, cw.RemoteAddr)
 	return
 }

server/middleware.go

@@ -1,9 +1,7 @@
 package server
 
 import (
-	"fmt"
 	"net"
-	"time"
 )
 
 type RequestMiddleware interface {
@@ -30,18 +28,6 @@ type RequestLogger struct {
 	remoteAddr  net.Addr
 }
 
-func NewRequestLogger(interaction Interaction, remoteAddr net.Addr) *RequestLogger {
-	return &RequestLogger{
-		interaction: interaction,
-		remoteAddr:  remoteAddr,
-	}
-}
-
-func (rl *RequestLogger) HandleRequest(header *RequestHeaderFactory) error {
-	rl.interaction.SendMessage(fmt.Sprintf("\033[32m%s %s -> %s %s \033[0m\r\n", time.Now().UTC().Format(time.RFC3339), rl.remoteAddr.String(), header.Method, header.Path))
-	return nil
-}
-
 type ForwardedFor struct {
 	addr net.Addr
 }

session/session.go

@@ -71,9 +71,6 @@ func New(conn *ssh.ServerConn, forwardingReq <-chan *ssh.Request, sshChan <-chan
 		SlugManager: slugManager,
 	}
 
-	go func() {
-		go session.Lifecycle.WaitForRunningStatus()
-
 	for channel := range sshChan {
 		ch, reqs, err := channel.Accept()
 		if err != nil {
@@ -85,6 +82,7 @@ func New(conn *ssh.ServerConn, forwardingReq <-chan *ssh.Request, sshChan <-chan
 			session.Interaction.SetChannel(ch)
 			session.Lifecycle.SetStatus(types.SETUP)
 			go session.HandleGlobalRequest(forwardingReq)
+			session.Lifecycle.WaitForRunningStatus()
 		})
 
 		go session.HandleGlobalRequest(reqs)
@@ -92,7 +90,6 @@ func New(conn *ssh.ServerConn, forwardingReq <-chan *ssh.Request, sshChan <-chan
 	if err := session.Lifecycle.Close(); err != nil {
 		log.Printf("failed to close session: %v", err)
 	}
-	}()
 }
 
 func updateClientSlug(oldSlug, newSlug string) bool {