Fix race conditions and improve lifecycle safety #150

2026-07-16T15:26:41+07:00

bagas commented

2026-07-16 15:26:41 +07:00

Summary

Comprehensive fixes for race conditions, concurrency bugs, and code quality improvements in the lifecycle module and related test files.

Changes

Race Condition Fixes

Fixed data race in SetChannel() and Channel() by adding mutex protection
Fixed data race in StartedAt() by adding mutex protection
Fixed test race conditions in transport and interaction packages where variables were shared between goroutines

Concurrency Safety Improvements

Refactored Close() to release mutex before calling external code, preventing potential deadlocks
Made SetChannel() reject calls after Close() to prevent setting channel on torn-down lifecycle
Made SetStatus() ignore calls after Close() to ensure CLOSED is a terminal state
Added nil check to SetChannel() to prevent masking upstream bugs

Code Quality Improvements

Refactored Close() to extract helper methods: closeChannel(), closeConnection(), cleanupRegistry(), cleanupForwarder()
Fixed isClosedError() to remove redundant string comparison
Added PortRegistry interface for better interface segregation (removed dependency on full port.Port)
Made cleanupRegistry() conditional on non-empty slug to avoid unnecessary registry calls
Fixed startedAt to be set when session starts running instead of at object creation

## Summary Comprehensive fixes for race conditions, concurrency bugs, and code quality improvements in the lifecycle module and related test files. ## Changes ### Race Condition Fixes - Fixed data race in `SetChannel()` and `Channel()` by adding mutex protection - Fixed data race in `StartedAt()` by adding mutex protection - Fixed test race conditions in `transport` and `interaction` packages where variables were shared between goroutines ### Concurrency Safety Improvements - Refactored `Close()` to release mutex before calling external code, preventing potential deadlocks - Made `SetChannel()` reject calls after `Close()` to prevent setting channel on torn-down lifecycle - Made `SetStatus()` ignore calls after `Close()` to ensure CLOSED is a terminal state - Added nil check to `SetChannel()` to prevent masking upstream bugs ### Code Quality Improvements - Refactored `Close()` to extract helper methods: `closeChannel()`, `closeConnection()`, `cleanupRegistry()`, `cleanupForwarder()` - Fixed `isClosedError()` to remove redundant string comparison - Added `PortRegistry` interface for better interface segregation (removed dependency on full `port.Port`) - Made `cleanupRegistry()` conditional on non-empty slug to avoid unnecessary registry calls - Fixed `startedAt` to be set when session starts running instead of at object creation

bagas changed target branch from main to staging

2026-07-16 17:30:58 +07:00

bagas added 7 commits 2026-07-16 17:30:58 +07:00

fix: use mutex on lifecycle efbff0f7f7

feat: seperate close function into tiny helper function 0a5f673c68

fix: change start date of lifecycle after running status 43d1ec0e6d

feat: make PortRegistry interface segregation f1df3d26c2

fix: read starttedAt with mutex on lifecycle 6ec57268db

fix: race condition test 6aa8c3bd48

fix: reject closing already closed lifecycle

Tests / Run Tests (pull_request) Successful in 2m36s

Details