staging #74

Merged

bagas merged 12 commits from staging into main 2026-01-22 22:16:34 +07:00

Conversation 0 Commits 12 Files Changed 38

+1763 -1397

bagas commented 2026-01-22 22:15:06 +07:00

Owner

Copy Link

No description provided.

bagas added 12 commits 2026-01-22 22:15:06 +07:00

fix: resolve copy goroutine deadlock on early connection close ... 8fb19af5a6

- Add proper CloseWrite handling to signal EOF to other goroutine
- Ensure both copy goroutines terminate when either side closes
- Prevent goroutine leaks for SSH forwarded-tcpip channels:
    - Use select with default when sending result to resultChan
    - Close unused SSH channels and discard requests if main goroutine has already timed out

refactor(session): simplify Start() and unify forwarding logic ... adb0264bb5

- Extract helper functions from Start() for better code organization
- Eliminate duplication with finalizeForwarding() method
- Consolidate denial logic into denyForwardingRequest()
- Update all handler methods to return errors instead of logging internally
- Improve error handling consistency across all operations

refactor(server): enhance HTTP handler modularity and fix resource leak ... 27f49879af

- Rename customWriter struct to httpWriter for clarity
- Add closeWriter field to properly close write side of connections
- Update all cw variable references to hw
- Merge handlerTLS into handler function to reduce code duplication
- Extract handler into smaller, focused methods
- Split Read/Write/forwardRequest into composable functions

Fixes resource leak where connections weren't properly closed on the
write side, matching the forwarder's CloseWrite() pattern.

refactor(forwarder): improve connection handling and cleanup ... aa1a465178

- Extract copyAndClose method for bidirectional data transfe
- Add closeWriter helper for graceful connection shutdown
- Add handleIncomingConnection helper
- Add openForwardedChannel helper

refactor: optimize header parsing and remove factory naming ... e3ead4d52f

- Remove factory naming
- Use direct byte indexing instead of bytes.TrimRight
- Extract parseStartLine and setRemainingHeaders helpers

refactor(httpheader): extract header parsing into dedicated package ... 9a4539cc02

Moved HTTP header parsing and building logic from server package to internal/httpheader

chore(restructure): reorganize project layout ... 1e12373359

- Reorganize internal packages and overall project structure
- Update imports and wiring to match the new layout
- Separate HTTP parsing and streaming from the server package
- Separate middleware from the server package
- Separate session registry from the session package
- Move HTTP, HTTPS, and TCP servers to the transport package
- Session package no longer starts the TCP server directly
- Server package no longer starts HTTP/HTTPS servers on initialization
- Forwarder no longer handles accepting TCP requests
- Move session details to the types package
- HTTP/HTTPS initialization is now the responsibility of main

refactor(config): centralize env loading and enforce typed access ... 2bc20dd991

- Centralize environment variable loading in config.MustLoad
- Parse and validate all env vars once at initialization
- Make config fields private and read-only
- Remove public Getenv usage in favor of typed accessors
- Improve validation and initialization order
- Normalize enum naming to be idiomatic and avoid constant collisions

ci: add sonarqube scan 1408b80917

refactor(lifecycle): reorder resource closing and simplify Close() ... 9f4c24a3f3

- Close channel and connection first, then remove session
- Close forwarded port and forwarder at the end for TCP tunnels
- Aggregate all errors using errors.Join instead of failing early

refactor(registry): define reusable constant errors ... 634c8321ef

- Introduced package-level error variables in registry to replace repeated fmt.Errorf calls
- Added errors like ErrSessionNotFound, ErrSlugInUse, ErrInvalidSlug, ErrForbiddenSlug, ErrSlugChangeNotAllowed, and ErrSlugUnchanged

chore(restructure): refactor architecture, config, and lifecycle management ... 961a905542

- Reorganized internal packages and overall project structure
- Moved HTTP/HTTPS/TCP servers into the transport layer
- Decoupled server initialization from HTTP/HTTPS/TCP startup logic
- Separated HTTP parsing, streaming, middleware, and session registry concerns
- Refactored session and forwarder responsibilities for clearer ownership
- Centralized environment loading with validated, typed config access
- Made config immutable after initialization and normalized enum naming
- Improved resource lifecycle handling and error aggregation on shutdown
- Introduced reusable, package-level registry errors
- Added SonarQube scanning to CI pipeline

Reviewed-on: #73

bagas merged commit d91eecb2a0 into main 2026-01-22 22:16:34 +07:00

bagas referenced this issue from a commit 2026-01-22 22:16:34 +07:00

chore: Refactor and optimize project architecture

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Renovate-Clanker bagas

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bagas/tunnel-please#74